Merge pull request #28 from Neovici/gh27

refs #27. Bug fix, null fix and updated devDep versions
Neovici · Dec 13, 2018 · 1609f7e · 1609f7e
2 parents 72a6ada + 8470e8d
commit 1609f7e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/cosmoz-dialog-behavior.html b/cosmoz-dialog-behavior.html
@@ -105,7 +105,7 @@
 				return;
 			}
 			step.call(this);
-			Polymer.Async.microTask.run(() => this._spawn);
+			Polymer.Async.microTask.run(() => this._spawn());
 		},
 		/**
 		 * Get the generated paper-dialog element
@@ -195,7 +195,7 @@
 				return;
 			}
 
-			Polymer.Async.microTask.run(() => this._spawn);
+			Polymer.Async.microTask.run(() => this._spawn());
 		},
 
 		_createDialog() {

diff --git a/cosmoz-form-dialog.html b/cosmoz-form-dialog.html
@@ -35,7 +35,7 @@
 			}
 
 			_detachDialog() {
-				if (this._form !== null && this._form.parentNode) {
+				if (this._form != null && this._form.parentNode) {
 					this._form.parentNode.removeChild(this._form);
 				}
 			}

diff --git a/package.json b/package.json
@@ -7,10 +7,10 @@
 		"test": "test"
 	},
 	"devDependencies": {
-		"eslint": "^4.10.0",
-		"eslint-plugin-html": "^3.2.2",
-		"eslint-plugin-mocha": "^4.11.0",
-		"polymer-cli": "^1.8.0",
+		"eslint": "^5.9.0",
+		"eslint-plugin-html": "^5.0.0",
+		"eslint-plugin-mocha": "^5.2.0",
+		"polymer-cli": "^1.9.1",
 		"web-component-tester-istanbul": "Neovici/web-component-tester-istanbul"
 	},
 	"scripts": {

diff --git a/test/cosmoz-dialog_test.html b/test/cosmoz-dialog_test.html
@@ -11,11 +11,13 @@
 
 	<link rel="import" href="../../test-fixture/test-fixture.html">
 	<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
+	<link rel="import" href="../../polymer/lib/elements/custom-style.html">
+	<link rel="import" href="../../shadycss/apply-shim.html">">
 
 	<link rel="import" href="../cosmoz-dialog.html">
 
 	<custom-style>
-		<style is="custom-style">
+		<style>
 			/* This will create a new stacking context above the dialog */
 			#stackingContext {
 				transform: translateX(0);