make long-running CPU tasks run on tokio's blocking threadpool. #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #122.
This PR makes the following potentially CPU intensive operations execute on tokio's blocking threadpool, so they do not block the tokio executor:
create_transaction_from_data()
which calls the proverTransaction
I am making this a PR rather than just pushing the commits for two reasons:
spawn_blocking()
expects a non-async fn, so I changed the (inner) mining loop so it doesn't make any async calls, which means it can't check the global statesyncing
flag. Instead the main loop notifies the (outer) mining loop when syncing starts and stops, which in turn halts or starts the (inner) mining loop which is running in tokio's threadpool. This should speed the inner mining loop a little, as it no longer needs to acquire a lock after computing each hash. Anyway, I thought @Sword-Smith may wish to review this change.note: #130 has macros for logging fn call duration. Once that is merged, we can easily log duration of any suspected targets to determine which are worth moving to the blocking threadpool.
Commits: