Fix Fast Reduce #215
Merged
Fix Fast Reduce #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was `structured_multiple` did not generate a multiple when the argument had trailing zeros. These were lost in the course of reversing.
|
Thanks for identifying and fixing the underlying issue. 👏 I think that would have taken me a very long time (and hope this was not the case for you). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
fast_reduce.Function
fast_reducedid not work when the modulus had structure, in particular when it had trailing zeros. The issue was thatstructured_multiplelost track of trailing zeros in the course of reversing coefficient vectors.