Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make Digest::LEN an associated const #218

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

jan-ferdinand
Copy link
Member

Also, deprecate digest::DIGEST_LENGTH.

I think this design is cleaner. It's a bit of a bikeshed. 馃し Open to suggestions.

@coveralls
Copy link

Coverage Status

coverage: 97.662%. remained the same
when pulling da94c99 on assoc_consts
into 60ed2b2 on master.

Copy link
Collaborator

@aszepieniec aszepieniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, yes and thanks ... but why do the tests fail?

Deprecate `digest::DIGEST_LENGTH`.
@jan-ferdinand
Copy link
Member Author

why do the tests fail?

Because I messed up a doc link. Fixed now. 馃憤

@coveralls
Copy link

Coverage Status

coverage: 97.073% (-0.6%) from 97.662%
when pulling cb53ad6 on assoc_consts
into 60ed2b2 on master.

@coveralls
Copy link

Coverage Status

coverage: 97.549% (-0.1%) from 97.662%
when pulling cb53ad6 on assoc_consts
into 60ed2b2 on master.

@jan-ferdinand
Copy link
Member Author

If I understand correctly, some randomized tests hit large swaths of code only occasionaly, leading to a rather big variance in code coverage. This feels like a separate issue.

@jan-ferdinand jan-ferdinand merged commit cb53ad6 into master Jun 21, 2024
5 checks passed
@jan-ferdinand jan-ferdinand deleted the assoc_consts branch June 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants