refactor: Make Digest::LEN an associated const
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszepieniec
requested changes
Jun 21, 2024
Deprecate `digest::DIGEST_LENGTH`.
jan-ferdinand
force-pushed
the
assoc_consts
branch
from
da94c99
to
cb53ad6
Compare
Because I messed up a doc link. Fixed now. 👍 |
aszepieniec
approved these changes
Jun 21, 2024
|
If I understand correctly, some randomized tests hit large swaths of code only occasionaly, leading to a rather big variance in code coverage. This feels like a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, deprecate
digest::DIGEST_LENGTH.I think this design is cleaner. It's a bit of a bikeshed. 🤷 Open to suggestions.