fix: replace inline destructure of apiResponse w conditional key opti…

…on-chain check

src/pages/CheckoutPage/CheckoutForm.tsx

@@ -6,22 +6,18 @@ import type { PaymentMethod } from "@stripe/stripe-js";
 /**
  * Displays a form with a Stripe card input.
  */
-export const CheckoutForm = ({
-  onCompleteCheckout,
-}: {
-  onCompleteCheckout: (success: boolean) => Promise<void>;
-}) => {
+export const CheckoutForm = ({ onCompleteCheckout }: CheckoutFormProps) => {
   const { selectedSubscription, promoCode } = checkoutValuesStore.useSubToStore() as CheckoutValues;
   const { submitPaymentForSubscription } = useStripeService();
 
   const handleSubmit = async (paymentMethod: PaymentMethod) => {
-    const { success } = await submitPaymentForSubscription({
+    const apiResponse = await submitPaymentForSubscription({
       selectedSubscription,
       paymentMethodID: paymentMethod.id,
       ...(!!promoCode && { promoCode }),
     });
 
-    await onCompleteCheckout(success);
+    await onCompleteCheckout(apiResponse?.success ?? false);
   };
 
   return (
@@ -36,3 +32,7 @@ export const CheckoutForm = ({
     />
   );
 };
+
+export type CheckoutFormProps = {
+  onCompleteCheckout: (success: boolean) => Promise<void>;
+};

src/pages/LoginPage/LoginForm.tsx

@@ -12,8 +12,8 @@ export const LoginForm = () => {
   const nav = useNavigate();
 
   const onSubmit = async (credentials: LoginParams) => {
-    const { success } = await login(credentials);
-    if (success) {
+    const apiResponse = await login(credentials);
+    if (apiResponse?.success === true) {
       toast.success("Welcome back!", { toastId: "login-success" });
       nav("/home");
     }

src/pages/RegisterPage/RegisterForm.tsx

@@ -22,9 +22,9 @@ export const RegisterForm = () => {
 
   const handleSubmit = async (values: RegisterNewUserParams) => {
     // Add "@" prefix to "handle"
-    const { success } = await registerNewUser({ ...values, handle: `@${values.handle}` });
+    const apiResponse = await registerNewUser({ ...values, handle: `@${values.handle}` });
 
-    if (success) {
+    if (apiResponse?.success === true) {
       /* If the user registered AFTER selecting a subscription from the /products page,
       locationState will contain their selectedSub in locationState.sub, which needs to
       be provided to the checkout page. If that property does not yet exist, nav to the