Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared): 创建component template支持'eh' #11478

Merged
merged 2 commits into from
Mar 28, 2022
Merged

feat(shared): 创建component template支持'eh' #11478

merged 2 commits into from
Mar 28, 2022

Conversation

bingtsingw
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
编译模版的时候, 将值为'eh'的属性编译为事件, 方便自定义组件时,可以自定义事件.

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

@taro-bot2
Copy link

taro-bot2 bot commented Mar 19, 2022

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

@bingtsingw
Copy link
Contributor Author

#9615

  1. config中配置@tarojs/plugin-inject
  plugins: [
    [
      '@tarojs/plugin-inject',
      {
        components: {
          CustomComponent: {
            catchtouchend: 'eh',
          },
        },
        componentsMap: {
          CustomComponent: 'custom-component',
        },
      },
    ],
  ],
  1. 按照文档配置global type
declare module '@tarojs/components' {
  export * from '@tarojs/components/types/index';

  import { ViewProps } from '@tarojs/components/types';
  import { ComponentType } from 'react';

  export const CustomComponent: ComponentType<ViewProps>;
}
  1. 在代码中使用
import { CustomComponent } from '@tarojs/components';

<CustomComponent
  onClick={() => {
    console.log('click');
  }}
  onTouchEnd={() => {
    console.log('touch end');
  }}
>
  {children}
</CustomComponent>

@Chen-jj Chen-jj merged commit 9a5eb39 into NervJS:next Mar 28, 2022
@Chen-jj
Copy link
Contributor

Chen-jj commented Mar 28, 2022

感谢贡献~

@baoxiangyang
Copy link

baoxiangyang commented Oct 24, 2023

@bingtsingw 如果我想只对某一个 添加了指定className的设置catchtouchend, 怎么玩呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants