Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro-components): H5 & Weapp统一pagePath. #2575

Merged
merged 1 commit into from
Mar 26, 2019
Merged

fix(taro-components): H5 & Weapp统一pagePath. #2575

merged 1 commit into from
Mar 26, 2019

Conversation

HuangHongRui
Copy link
Contributor

问题:

//    例子.
tabBar: {
    ............................
    ............................
      "list": [
        {
          "pagePath": "pages/xxxx/index",   //问题点
          "text": "Xx",
          ....
        },
    ............................
    ............................
    }

pagePathpages/xxxx/index
小程序环境:正常.
H5 环境: 被隐藏.

pagePath/pages/xxxx/index // 注意:多了个 “/” 字符
小程序环境:报错 (tabBar[0].pagePath should not begin with '/')
H5环境:正常

处理:
统一格式:pages/xxxx/index
H5拿到 PagePath 后在其头部增加 '/'

@Littly Littly self-requested a review March 25, 2019 11:16
Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不错~ 不过麻烦把 commit log 改一下,按照 type(scope): message 的格式

@Littly Littly self-requested a review March 25, 2019 11:20
Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不错~ 不过麻烦把 commit log 改一下,按照 type(scope): message 的格式

@HuangHongRui HuangHongRui changed the title [Fix] TabBar _ PagePath 兼容. flx (taro-components): H5 & Weapp统一pagePath. Mar 25, 2019
@HuangHongRui
Copy link
Contributor Author

Done.

@HuangHongRui HuangHongRui changed the title flx (taro-components): H5 & Weapp统一pagePath. flx(taro-components): H5 & Weapp统一pagePath. Mar 25, 2019
@Littly Littly merged commit cdd1370 into NervJS:master Mar 26, 2019
@HuangHongRui HuangHongRui changed the title flx(taro-components): H5 & Weapp统一pagePath. fix(taro-components): H5 & Weapp统一pagePath. Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants