Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(h5): request的get请求数据为复杂结构不能正确发送的问题 #3659

Merged
merged 1 commit into from
Aug 12, 2019
Merged

fix(h5): request的get请求数据为复杂结构不能正确发送的问题 #3659

merged 1 commit into from
Aug 12, 2019

Conversation

YuanQuan
Copy link
Contributor

@YuanQuan YuanQuan commented Jul 3, 2019

这个 PR 做了什么? (简要描述所做更改)
Get请求,发现如果传递的参数是多层的,直接会变成object字符串,参考微信小程序原生功能,对多层对象进行json转string操作。

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

@nevernet
Copy link

nevernet commented Jul 3, 2019

非必须, 其实这个封装更建议放到自己的代码里面。 毕竟如果是复杂结构, 这种JSON.stringfy就成黑盒了

@YuanQuan
Copy link
Contributor Author

YuanQuan commented Jul 3, 2019

我这边只是希望可以跟微信的效果一致,不然其它人移植的难度都会加大一点点

@YuanQuan
Copy link
Contributor Author

YuanQuan commented Jul 8, 2019

@Littly 看一下 这个需要么

@luckyadam
Copy link
Member

同意 @nevernet ,这种逻辑建议自己封装一下

Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实有必要,否则h5端传对象会直接变成[object Object],容易让人困惑。

@Littly Littly merged commit 1f51650 into NervJS:master Aug 12, 2019
yuezk added a commit to yuezk/taro that referenced this pull request Oct 9, 2020
@yuezk yuezk mentioned this pull request Oct 9, 2020
20 tasks
yuezk added a commit to yuezk/taro that referenced this pull request Oct 9, 2020
@yuezk yuezk mentioned this pull request Oct 9, 2020
20 tasks
luckyadam added a commit that referenced this pull request Oct 9, 2020
introduced with #3659

Co-authored-by: Li,Weitao <weitaozsh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants