Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom-routes for path-match fix #6388 #6421

Merged
merged 2 commits into from
Jun 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 19 additions & 3 deletions packages/taro-router/src/router/route.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
import Taro from '@tarojs/taro-h5'
import Nerv, { nextTick } from 'nervjs'
import toPairs from 'lodash/toPairs'

import { tryToCall } from '../utils'
import { Location, RouteObj } from '../utils/types'
import createWrappedComponent from './createWrappedComponent'

import * as Types from '../utils/types'

type RouteProps = RouteObj & {
currentLocation: Location;
k: number;
collectComponent: Function;
customRoutes: Types.CustomRoutes;
}

const getScroller = () => {
Expand All @@ -32,40 +36,52 @@ const getScroller = () => {
}
let scroller

type OriginalRoute = string;
type MappedRoute = string;

class Route extends Taro.Component<RouteProps, {}> {
matched = false;
wrappedComponent;
componentRef;
containerRef;
isRoute = true;
scrollPos = 0;
customRoutes: [OriginalRoute, MappedRoute][] = [];

state = {
location: {}
}

constructor (props, context) {
super(props, context)
this.customRoutes = toPairs(this.props.customRoutes)
this.matched = this.computeMatch(this.props.currentLocation)
if (this.matched) {
this.state = { location: this.props.currentLocation }
}
}

computeMatch (currentLocation: Location) {
const path = currentLocation.path;
let pathname = currentLocation.path;
const key = currentLocation.state.key;
const isIndex = this.props.isIndex;
const isTabBar = this.props.isTabBar;

const foundRoute = this.customRoutes.filter(([originalRoute, mappedRoute]) => {
return currentLocation.path === mappedRoute
})
if (foundRoute.length) {
pathname = foundRoute[0][0]
}

if (key !== undefined) {
if (isTabBar) {
return key === this.props.key && path === this.props.path
return key === this.props.key && pathname === this.props.path
} else {
return key === this.props.key
}
} else {
return isIndex && path === '/'
return isIndex && pathname === '/'
}
}

Expand Down
18 changes: 14 additions & 4 deletions packages/taro-router/src/router/router.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,17 @@ class Router extends Taro.Component<Props, State> {
}
}

isTabBar (path: string) {
isTabBar (originalPathname: string) {
let pathname = originalPathname
const foundRoute = this.customRoutes.filter(([originalRoute, mappedRoute]) => {
return originalPathname === mappedRoute
})
if (foundRoute.length) {
pathname = foundRoute[0][0]
}
const tabBar = this.props.tabBar
if (path && tabBar && tabBar.list && tabBar.list instanceof Array) {
return tabBar.list.findIndex(e => e.pagePath === path) !== -1
if (foundRoute && tabBar && tabBar.list && tabBar.list instanceof Array) {
return tabBar.list.findIndex(e => e.pagePath === pathname) !== -1
}
return false
}
Expand Down Expand Up @@ -125,7 +132,9 @@ class Router extends Taro.Component<Props, State> {
switch (toLocation: Types.Location, isTabBar = false) {
const routeStack: Types.RouteObj[] = [...this.state.routeStack]
const matchedRoute = this.computeMatch(toLocation)
const index = routeStack.findIndex(e => e.path === toLocation.path)
const index = routeStack.findIndex(e => e.path === toLocation.path || this.customRoutes.findIndex(([originalRoute, mappedRoute]) => {
return mappedRoute === toLocation.path && e.path === originalRoute
}) !== -1)
if (!this.isTabBar(routeStack[routeStack.length - 1].path)) {
routeStack.splice(-1, 1, assign({}, matchedRoute, {
key: toLocation.state.key,
Expand Down Expand Up @@ -212,6 +221,7 @@ class Router extends Taro.Component<Props, State> {
return (
<Route
path={path}
customRoutes={this.props.customRoutes}
currentLocation={currentLocation}
componentLoader={componentLoader}
isIndex={isIndex}
Expand Down