Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 h5 使用 pageScrollTo 将 scrollTop 设置为 0 会报错的问题 #8408

Merged
merged 2 commits into from Jan 29, 2021
Merged

Conversation

jin-yufeng
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
pageScrollTo 中的 scrollTop 参数可能为 0,用 !scrollTop 来判断会导致设置为 0 时报错,因此应该修改为 scrollTop === undefined

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@qiuziz
Copy link
Contributor

qiuziz commented Apr 16, 2021

https://github.com/NervJS/taro/blob/next/packages/taro-h5/src/api/scroll/index.js#L61
image
此问题还需修改这里,不传selector,传scrollTop: 0 这里会报错
image
@jin-yufeng @ZakaryCode @Chen-jj

3.2.1

@jin-yufeng
Copy link
Contributor Author

https://github.com/NervJS/taro/blob/next/packages/taro-h5/src/api/scroll/index.js#L61
image
此问题还需修改这里,不传selector,传scrollTop: 0 这里会报错
image
@jin-yufeng @ZakaryCode @Chen-jj

3.2.1

是的,当时没发现

@ZakaryCode ZakaryCode added this to Done in H5 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-h5 Target - 编译到 H5 V-3 Version - 3.x
Projects
Archived in project
H5
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants