Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Fix building on centos with gcc 4.8.5 #2913

Merged
merged 4 commits into from May 13, 2019
Merged

Fix building on centos with gcc 4.8.5 #2913

merged 4 commits into from May 13, 2019

Conversation

rkimballn1
Copy link
Contributor

@rkimballn1 rkimballn1 commented May 11, 2019

These changes are required to make this work on Centos.
Centos is doing things differently with the following syntax
auto scale_node{get_argument(1)};
While gcc on ubuntu sets scale_node to a shared_ptr<Node>, centos makes an initializer_list<shared_ptr<Node>>. Yet another reason to avoid the auto keyword.

Copy link
Contributor

@arogowie-intel arogowie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! I saw this once on CI, however later CI passed.

@silee2
Copy link
Contributor

silee2 commented May 13, 2019

I see the same issue with latest ICC. "auto" with C++ uniform initialization syntax does not seem to be well defined for C++11.

@aprocter aprocter added the Fully Reviewed PR is approved by all reviewers. label May 13, 2019
@diyessi diyessi merged commit f813fb6 into master May 13, 2019
@diyessi diyessi deleted the bob/centos_fix branch May 13, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fully Reviewed PR is approved by all reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants