Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for fire tv on the keyboard #62

Closed
armedad opened this issue Feb 16, 2024 · 11 comments
Closed

support for fire tv on the keyboard #62

armedad opened this issue Feb 16, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@armedad
Copy link

armedad commented Feb 16, 2024

the current keyboards don't work completely on fire tv. keys like backspace, delete, etc are handled differently than chromecast

i'd love to be able to override arbitrary keys. this would allow me to even replace the handling of alpha numerics. but alternatively alternate keyboard_mode like kodi (as you suggested in the community thread) would solve for these specific keys.

@armedad armedad added the enhancement New feature or request label Feb 16, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented Feb 17, 2024

Keyboards (seamless, textbox, and search) are programmed differently than regular buttons and wouldn't be remappable without a major rewrite. Adding new keyboard modes for different platforms makes more sense since there are a finite number of platforms and variations that need to be supported.

I opted to use the Android Remote API commands for backspace, delete, enter, arrow left, and arrow right since they're much more performant, but can create an alternate Fire TV keyboard mode which sends these commands via ADB. I'll work on this along with a couple of other feature requests for the next minor version and share a beta here when it's ready.

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 17, 2024

Implemented in 3.4.0, which is still in alpha as I implement other feature requests. Set keyboard_mode to FIRE TV, and then backspace, delete, enter, and arrow left and right will be sent using ADB instead of the remote API.

@Nerwyn Nerwyn self-assigned this Feb 17, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented Feb 17, 2024

Ready to for testing and feedback in the latest beta!

@Nerwyn Nerwyn assigned armedad and unassigned Nerwyn Feb 22, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented Feb 22, 2024

@armedad still waiting for your feedback

@armedad
Copy link
Author

armedad commented Feb 23, 2024

i'm getting "failed to call service/send_command, must contain at least one of entity_id, device_id, area_id

i only get that error on backspace/enter (don't have arrows to test). alpha numerics and other character keys work fine.

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 23, 2024

I'm not getting that error in my testing. The entity ID for keyboard calls is being set here and is being done pretty much the same way as it's done for alphanumeric keys. Have you tried clearing cache? This sounds like it could be a caching issue.

@armedad
Copy link
Author

armedad commented Feb 23, 2024 via email

@armedad
Copy link
Author

armedad commented Feb 23, 2024 via email

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 23, 2024

I'd have to reconfigure my build pipeline to spit out a non-minified copy of the card JS file, and I'm not sure if I want to deal with that headache. Glad to hear that it works!

@armedad
Copy link
Author

armedad commented Feb 23, 2024 via email

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 26, 2024

Added in 3.4.0

@Nerwyn Nerwyn closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants