Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor change] Add aggregate attribute to client scope model #455

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[Minor change] Add aggregate attribute to client scope model #455

merged 1 commit into from
Jan 2, 2024

Conversation

vikram-deepfactor
Copy link
Contributor

@vikram-deepfactor vikram-deepfactor commented Dec 21, 2023

Thanks for your contribution!
Hi, if there is an issue, that your PR adresses, please link it!

  • Added field aggregate.attrs to client scope, which supports aggregation of multiple values
  • Tested locally

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba0216d) 77.26% compared to head (a13ebcb) 77.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files           4        4           
  Lines        2261     2261           
=======================================
  Hits         1747     1747           
  Misses        345      345           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nerzal Nerzal merged commit 2d728e2 into Nerzal:main Jan 2, 2024
6 checks passed
@Nerzal
Copy link
Owner

Nerzal commented Jan 2, 2024

LGTM, thank you !

@vikram-deepfactor vikram-deepfactor deleted the client_scope_attribute_addition branch January 2, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants