Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for users-management-permissions get/put #463

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

tomqwpl
Copy link
Contributor

@tomqwpl tomqwpl commented Feb 1, 2024

Issues/#462

@tomqwpl
Copy link
Contributor Author

tomqwpl commented Feb 1, 2024

@Nerzal I'm assuming that the test failures on this PR are nothing to do with the changed code?

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (ba0216d) 77.26% compared to head (5776405) 76.69%.
Report is 2 commits behind head on main.

Files Patch % Lines
client.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   77.26%   76.69%   -0.58%     
==========================================
  Files           4        4              
  Lines        2261     2278      +17     
==========================================
  Hits         1747     1747              
- Misses        345      362      +17     
  Partials      169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nerzal Nerzal merged commit fec0d9e into Nerzal:main Feb 1, 2024
4 of 6 checks passed
@Nerzal
Copy link
Owner

Nerzal commented Feb 1, 2024

LGTM, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants