Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philosopher does not allow certain characters in Gene names #407

Closed
fstein opened this issue Jan 27, 2023 · 2 comments
Closed

Philosopher does not allow certain characters in Gene names #407

fstein opened this issue Jan 27, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fstein
Copy link

fstein commented Jan 27, 2023

Dear Felipe,

With the new philosopher version 4.8.1, I got the following error:

The proteion record [tr|Q1RMN8|Q1RMN8_BOVIN Immunoglobulin light chain, lambda gene cluster OS=Bos taurus GN=IGL@ PE=2 SV=1] contains an unsupported character: @. Please remove it before running philosopher again
Process 'PhilosopherDbAnnotate' finished, exit code: 2
Process returned non-zero exit code, stopping

This error did not occur with previous versions. And IGL@ is indead the correct gene name (see here: https://www.uniprot.org/uniprotkb/Q1RMN8/entry).

Thanks for taking care of this.

Best,

Frank

@prvst
Copy link
Collaborator

prvst commented Jan 27, 2023

Thanks for letting me know that. The reason is because IonQuant can't handle @ in FASTA headers. If there's genes names with @, then IonQuant needs to be fixed. I'll push it forward to FragPipe issue, and I'll plan to revert this in the next release.

@prvst prvst self-assigned this Jan 27, 2023
@prvst prvst added the enhancement New feature or request label Jan 27, 2023
@prvst
Copy link
Collaborator

prvst commented Jan 30, 2023

Removed. Added to v4.9.2

@prvst prvst closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants