Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui fixes #255

Merged
merged 32 commits into from
Mar 6, 2017
Merged

Ui fixes #255

merged 32 commits into from
Mar 6, 2017

Conversation

rtxm
Copy link
Collaborator

@rtxm rtxm commented Mar 3, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 47.286% when pulling f5d2d28 on ui_fixes into 309b016 on master.

Copy link
Collaborator

@vrialland vrialland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the missing "dist" directory, it looks good to me.

@@ -140,7 +140,9 @@ def render_kansha(self, h, comp, *args):
h.head.javascript_url('js/kansha.js')
h.head.javascript_url('js/autocomplete.js')

h.head.javascript_url('js/ckeditor-4.5.3/ckeditor.js')
h.head.javascript_url('js/wysihtml/dist/minified/wysihtml.min.js')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist directory is missing from the sources (or do I have to build it somewhere ?)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 47.279% when pulling f71a217 on ui_fixes into 309b016 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 47.279% when pulling 409c73d on ui_fixes into 309b016 on master.

@rtxm
Copy link
Collaborator Author

rtxm commented Mar 3, 2017

Thanks @vrialland, gitignore hit me.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 47.279% when pulling e907c63 on ui_fixes into 309b016 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 47.32% when pulling d64b5c2 on ui_fixes into 309b016 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 47.308% when pulling a15e578 on ui_fixes into 309b016 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 47.308% when pulling 159a926 on ui_fixes into 309b016 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 47.308% when pulling a3842d0 on ui_fixes into 309b016 on master.

@rtxm rtxm merged commit 29e3f4f into master Mar 6, 2017
@rtxm rtxm deleted the ui_fixes branch March 7, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants