fix: handled review comments

NetApp · Feb 23, 2023 · 9724973 · 9724973
1 parent f104c08
commit 9724973
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/cmd/tools/grafana/dashboard_test.go b/cmd/tools/grafana/dashboard_test.go
@@ -228,7 +228,8 @@ func doPanel(t *testing.T, pathPrefix string, key gjson.Result, value gjson.Resu
 
 	// In case of gradient-gauge and percent(0.0-1.0), we must override min and max value
 	for _, properties := range propertiesMap {
-		if properties["unit"] == "percentunit" && properties["custom.displayMode"] == "gradient-gauge" {
+		displayMode := properties["custom.displayMode"]
+		if properties["unit"] == "percentunit" && (displayMode == "gradient-gauge" || displayMode == "lcd-gauge" || displayMode == "basic") {
 			if maxVal, exist := properties["max"]; !exist || maxVal != "1" {
 				t.Errorf("dashboard=%s, title=%s should have max value 1", sPath, title)
 			}