Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http sd to docker #672

Closed
rahulguptajss opened this issue Nov 17, 2021 · 1 comment · Fixed by #678
Closed

Add http sd to docker #672

rahulguptajss opened this issue Nov 17, 2021 · 1 comment · Fixed by #678
Labels
feature New feature or request priority/P1 status/done

Comments

@rahulguptajss
Copy link
Contributor

No description provided.

@rahulguptajss rahulguptajss added the feature New feature or request label Nov 17, 2021
@rahulguptajss rahulguptajss self-assigned this Nov 17, 2021
@rahulguptajss rahulguptajss linked a pull request Dec 2, 2021 that will close this issue
feat: admin with docker compose #678
Merged
@cgrinds cgrinds assigned cgrinds and unassigned rahulguptajss Feb 10, 2022
@cgrinds cgrinds reopened this Feb 11, 2022
rahulguptajss added a commit that referenced this issue Feb 11, 2022
@rahulguptajss
feat: cert dir for admin
7e4a349 
Fixes #672
@rahulguptajss rahulguptajss mentioned this issue Feb 11, 2022
Merged
cgrinds pushed a commit that referenced this issue Feb 11, 2022
@rahulguptajss @cgrinds
feat: cert dir for admin
727e0b5 
Fixes #672
@cgrinds cgrinds assigned cgrinds and unassigned rahulguptajss Feb 11, 2022
@cgrinds
Copy link
Collaborator

cgrinds commented Feb 11, 2022

Verified on release/22.02.0 727e0b5

If you use tls certificates with your admin node, and your admin node is also running in a container, you need to include the container name as a valid dnsname when creating the certificate. For example, if your admin node is setup like this in harvest.yml

Admin:
    httpsd:
      listen: admin:8887   <== hostname was changed to admin to match the container name
      tls:
        cert_file: cert/admin-cert.pem
        key_file: cert/admin-key.pem

you need to make sure when you create the TLS certificates, you include an additional admin dnsname like so:

bin/harvest admin tls create server --dnsname admin

If you don't include the additional dnsname, the pollers will not be able to connect to the admin node running in the container. The admin node logs will show errors like this:

2022/02/11 15:05:21 http: TLS handshake error from 172.23.0.2:47592: remote error: tls: bad certificate

@cgrinds cgrinds closed this as completed Feb 11, 2022
rahulguptajss added a commit that referenced this issue Feb 16, 2022
@rahulguptajss @cgrinds
feat: release to main merge (#856)
4efbfba 
* Revert "fix: dashboards variables should support multi-select"

This reverts commit 9fb6619.

* ci: pin go version

* feat: cert dir for admin

Fixes #672

* docs: changelog for 22.02 (#854)

* docs: changelog for 22.02

* docs: changelog for 22.02

* docs: changelog for 22.02

* docs: changelog for 22.02

Co-authored-by: Chris Grindstaff <chris@gstaff.org>
@cgrinds cgrinds removed their assignment May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request priority/P1 status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: admin with docker compose NetApp/harvest
3 participants
@cgrinds @rahulguptajss @ruanruijuan