Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handling sub-panels while importing with prefix #1645

Merged
merged 5 commits into from
Jan 9, 2023
Merged

fix: handling sub-panels while importing with prefix #1645

merged 5 commits into from
Jan 9, 2023

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Jan 2, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 2, 2023
@Hardikl Hardikl linked an issue Jan 2, 2023 that may be closed by this pull request
Prefix (-p option) does not add prefix to all panels #1643
Closed
cgrinds
cgrinds previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we should consider replacing the prefixing logic with gjson and reuse the code we've added for dashboard unit tests. That code is very similar

@cgrinds cgrinds merged commit 3489d63 into main Jan 9, 2023
@cgrinds cgrinds deleted the prefix_issue branch January 9, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@rahulguptajss rahulguptajss rahulguptajss approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix (-p option) does not add prefix to all panels
3 participants
@Hardikl @cgrinds @rahulguptajss