Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing status metric in security_cert as nowhere used #1651

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix: removing status metric in security_cert as nowhere used #1651

merged 1 commit into from
Jan 6, 2023

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Jan 6, 2023

Compared ZAPI and REST,

Security_certificate would have 2 metrics,

  1. security_certitifcate_labels which contains all labels
  2. security_certificate_expiry_time timestamp of expiry

image

image

@cla-bot cla-bot bot added the cla-signed label Jan 6, 2023
@Hardikl Hardikl linked an issue Jan 6, 2023 that may be closed by this pull request
investigate security_certificate_status metric in harvest #1650
Closed
@Hardikl Hardikl merged commit 312fa85 into main Jan 6, 2023
@Hardikl Hardikl deleted the security_cert branch January 6, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@rahulguptajss rahulguptajss Awaiting requested review from rahulguptajss rahulguptajss is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate security_certificate_status metric in harvest
2 participants
@Hardikl @cgrinds