Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude node/svm vols and include data svms #1658

Merged
merged 12 commits into from
Jan 25, 2023
Merged

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Jan 12, 2023

Naming conventions
volume

  • svm_root volume name: xxx_root
  • node_root volume name: vol0

SVM

  • system_svm: cluster
  • node_svm: node name
  • admin_svm: cluster name

Before applying on template level filter

Volume:
svm_root: 16
image

node_root:2
image

total volume:527
image

SVM:
data svm:17
image

node,system,admin svm: 4
image

total svm: 21
image

After applying the template level filter
Volume:
total volume: 509
image

SVM:
total svm: 17
image

@Hardikl
Copy link
Contributor Author

Hardikl commented Jan 13, 2023

For REST,

  • Volume public api provide all volumes but node, We only need to exclude root svm vols in template.
  • SVM private api provide all svms but system, We only need to include data svms in template.

@rahulguptajss
Copy link
Contributor

I think we should export root vols/svm where applicable and only hide them from dashboards?

@Hardikl
Copy link
Contributor Author

Hardikl commented Jan 17, 2023

I think we should export root vols/svm where applicable and only hide them from dashboards?

Yes, We should.
The thought process behind this template filter is, If customer want to exclude/include root objs, they can do via template change which would be easier than query changes in dashboard.

@Hardikl Hardikl linked an issue Jan 18, 2023 that may be closed by this pull request
@Hardikl
Copy link
Contributor Author

Hardikl commented Jan 24, 2023

image

Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Hardikl

@rahulguptajss rahulguptajss merged commit ecbdaeb into main Jan 25, 2023
@rahulguptajss rahulguptajss deleted the root_objs branch January 25, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONTAP: cDOT Dashboard - Ignore Node SVMs and vol0 volums
3 participants