-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exclude node/svm vols and include data svms #1658
Conversation
For REST,
|
I think we should export root vols/svm where applicable and only hide them from dashboards? |
Yes, We should. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @Hardikl
Naming conventions
volume
SVM
Before applying on template level filter
Volume:
![image](https://user-images.githubusercontent.com/83282894/212044855-b7aa79a5-3f97-48fd-98ab-126adfcc0805.png)
svm_root: 16
node_root:2
![image](https://user-images.githubusercontent.com/83282894/212044905-b312df6b-66db-49d1-b020-b02ea2000e42.png)
total volume:527
![image](https://user-images.githubusercontent.com/83282894/212044974-1151c3cb-304a-4cba-ad12-fc31609fb52a.png)
SVM:
![image](https://user-images.githubusercontent.com/83282894/212045797-0826b538-c558-417f-a2d4-a02e1739f3a8.png)
data svm:17
node,system,admin svm: 4
![image](https://user-images.githubusercontent.com/83282894/212046005-1e3bf4de-18e7-462b-98df-14daf86e3bbc.png)
total svm: 21
![image](https://user-images.githubusercontent.com/83282894/212045898-ba686db6-fb5f-4b5a-9a9c-9051a5f84e51.png)
After applying the template level filter
![image](https://user-images.githubusercontent.com/83282894/212083100-b7474047-2140-4115-a94b-3c1b35760d95.png)
Volume:
total volume: 509
SVM:
![image](https://user-images.githubusercontent.com/83282894/212081655-da9a3498-7162-4b08-9ec4-e926abd998fa.png)
total svm: 17