Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: weighted avg support in aggregator plugin #1672

Merged
merged 5 commits into from
Jan 30, 2023
Merged

feat: weighted avg support in aggregator plugin #1672

merged 5 commits into from
Jan 30, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2023
@rahulguptajss rahulguptajss linked an issue Jan 30, 2023 that may be closed by this pull request
volume summary metrics mismatch #1666
Closed
Hardikl
Hardikl previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add one test in aggregator_test for this.

cgrinds
cgrinds reviewed Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

cmd/poller/plugin/aggregator/aggregator.go Outdated Show resolved Hide resolved
cmd/poller/plugin/aggregator/aggregator.go Outdated Show resolved Hide resolved
@cgrinds
Copy link
Collaborator

cgrinds commented Jan 30, 2023

Should update cmd/tools/generate/counter.yaml with node_volume_read_latency, node_volume_write_latency, node_volume_other_latency

@rahulguptajss
Copy link
Contributor Author

They are generated through plugins. I'll add all of these including other plugins in a seperate PR.

@rahulguptajss
Copy link
Contributor Author

Would be good to add one test in aggregator_test for this.

added

@rahulguptajss rahulguptajss merged commit 5448a77 into main Jan 30, 2023
@rahulguptajss rahulguptajss deleted the rg2-weighted_avg branch January 30, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@Hardikl Hardikl Hardikl left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volume summary metrics mismatch
3 participants
@rahulguptajss @cgrinds @Hardikl