fix: backward compatibility for qtree template #1679
Conversation
|
Added minor change in older template to fetch only Reason: We have only one Metrics when changed to qtree.22.05.yaml in default.yaml. qtree_disk_limit: quota_disk_limit: Points:
|
|
Case 1: Same behaviour as Harvest 22.05 qtree_disk_limit: quota_xxxx metrics not exist. Case 2: Current Harvest behaviour qtree_disk_limit: quota_disk_limit: |
|
Change update in PR: |
|
|
||
| // apply all instance keys, instance labels from parent (qtree.yaml) to all quota metrics | ||
| //parent instancekeys would be added in plugin metrics | ||
| for _, parentKeys := range my.ParentParams.GetChildS("export_options").GetChildS("instance_keys").GetAllChildContentS() { |
There was a problem hiding this comment.
are we sure that each of these nodes will be present, otherwise we will panic on nil
There was a problem hiding this comment.
It's export section from qtree template, it should always be there to define which keys/labels would be exported for qtree.
In 22.05,
qtree_labels:
qtree_disk_llimit:
No quota_xxx metrics exist.
In 23.02, without any changes,
qtree_labels:
qtree_disk_limit:
quota_disk_limit:
In 23.02, with changes with qtree.yaml,
qtree_labels:
qtree_disk_limit:
quota_disk_limit:
In 23.02, when changed from qtree.yaml to qtree.22.05.yaml in default.yaml
qtree_labels:
qtree_disk_limit:
quota_disk_limit:
Points:
qtree_labelswould be same in both the template.qtree_labelswould be differ in both template --> reason: latest template excludes empty qtree names.Current Issue: