-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: variable DS_PROMETHEUS should exist in dashboard #1688
Conversation
test: add unit test to ensure variable exists
# grid-01: | ||
# datacenter: DC-01 | ||
# addr: 10.0.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be example should have port also for SG prometheus?
# password: mypass | ||
# collectors: | ||
# - StorageGrid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to mention example of another prometheus which has storagegrid metrics exported.
test: add unit test to ensure variable exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update link in this doc. It is pointing to
https://github.com/NetApp/harvest/blob/main/docs/AuthAndPermissions.md#using-certificate-authentication
test: add unit test to ensure variable exists
test: add unit test to ensure variable exists