Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add error log when collector fails due to connection issues #1731

Merged
merged 1 commit into from
Feb 15, 2023
Merged

fix: add error log when collector fails due to connection issues #1731

merged 1 commit into from
Feb 15, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 14, 2023
@cgrinds
Copy link
Collaborator

cgrinds commented Feb 15, 2023

Can you make sure this is not handled lower in the stack? I thought it was, and that's why we were returning a Harvest error.

@rahulguptajss
Copy link
Contributor Author

Can you make sure this is not handled lower in the stack? I thought it was, and that's why we were returning a Harvest error.

This error is not returned but only printed. We are running loop of all collector objects and printing for ones , there are errors.

@cgrinds cgrinds merged commit bd4ab1e into release/23.02.0 Feb 15, 2023
@cgrinds cgrinds deleted the rg2-err-on-conn branch February 15, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardikl Hardikl Hardikl approved these changes

@cgrinds cgrinds Awaiting requested review from cgrinds cgrinds is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahulguptajss @cgrinds @Hardikl