fix: topk suppport in 3 panels in snapmirror dashboard #1735
Conversation
Hardikl
commented
Feb 15, 2023
Hardikl
commented
| @@ -882,15 +882,15 @@ | |||
| "pluginVersion": "8.1.8", | |||
| "targets": [ | |||
| { | |||
| "expr": "avg (snapmirror_last_transfer_duration{source_cluster=~\"$SourceCluster\",source_volume=~\"$SourceVolume\",destination_volume=~\"$DestinationVolume\"}) by (relationship_id)", | |||
There was a problem hiding this comment.
avg by relationship_id doesn't do any work as relationship_id is unique
| "format": "table", | ||
| "instant": true, | ||
| "interval": "", | ||
| "legendFormat": "", | ||
| "refId": "C" | ||
| }, | ||
| { | ||
| "expr": "avg(snapmirror_last_transfer_size{source_cluster=~\"$SourceCluster\",source_volume=~\"$SourceVolume\",destination_volume=~\"$DestinationVolume\"}) by (relationship_id)", | ||
| "expr": "snapmirror_last_transfer_size{source_cluster=~\"$SourceCluster\",source_volume=~\"$SourceVolume\",destination_volume=~\"$DestinationVolume\",relationship_id=~\"$TopTransferDataById\"}", |
There was a problem hiding this comment.
it feels a bit surprising that the Last Transfers table is filtered by topk size. We should probably update the title of this panel to make that clear. Not sure folks will understand that the number of rows shown is a function of topk
There was a problem hiding this comment.
Changed to Top $TopResources Last Transfers by Transfer Data Size
There was a problem hiding this comment.
may be give an all option in topk? Also this table should have filtering enabled.
There was a problem hiding this comment.
added filter for all columns.
For all option in topk,
Currently 500 is max value in topk. May be we provide highest value as some ~K, which gives all records.
There was a problem hiding this comment.
you mean enable All label in dropdown and give it a very high value?
There was a problem hiding this comment.
As topk(100, snapmirror_labels) function only allow number as arg not string, I would be thinking this way:
There was a problem hiding this comment.
Tried this, But topk query would fail with this because not able to parse |.
There was a problem hiding this comment.
Try setting a custom value for topk. Works fine for me.
There was a problem hiding this comment.
Missed the custom all value....
made the changes for All.
|
Not sure if this was introduced by your change, but looks like a column is missing? |
it was there earlier, and not related to this table, so removed them. |
|
|
