fix: backward compatibility for qtree metrics in rest #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardikl
changed the title
Hardikl
force-pushed
the
qtree_backward_comp
branch
from
fb8e55e
to
98ccc9f
Compare
Hardikl
commented
Mar 1, 2023
conf/rest/9.12.0/qtree.yaml
Outdated
Comment on lines
14
to
15
| - filter: | ||
| - name=!"" |
There was a problem hiding this comment.
As 22.05 behaviour would need all qtrees, I have removed this filter and later filtered with exclude_equals
There was a problem hiding this comment.
Wouldn't it be better to ask Customer using 22.05 version make this change to template themselves?
There was a problem hiding this comment.
Yes, can be possible.
As the REST don't support merge of custom template, We can ask them to create this custom rest template as mentioned here #1784, I will update the PR and the steps accordingly so no changes would be required in current template.
There was a problem hiding this comment.
Updated the PR, we don't need to change the steps mentioned in #1784.
rahulguptajss
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with REST collector,
metrics behaviour in Harvest 22.05
qtree_labels:
qtree_disk_limit:
quota_disk_limit:
metrics behaviour in latest Harvest
Case1: Same behaviour as Harvest 22.05
with hidden key-val pair
qtree_labels:
qtree_disk_limit:
quota_disk_limit:
Case2: Current Harvest behaviour
without hidden key-val pair:
qtree_labels:
qtree_disk_limit:
quota_disk_limit:
