-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch few counters from ONTAP instead of UM api #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest changes?
UM api response:
Harvest 2.0 response:
The above 3 are fetched from volume level and cumulated in AU in UM.
|
For REST changes, QTREE: full mapping working on Volume and Aggregate Rest mapping. |
For REST changes,
|
May be we only add what we have available in Zapi else it will remain as gap in Rest for long. Have you checked private cli? Also does any of these metrics used in dashboards in 1.6? |
For REST changes,
|
-> Yes, Agreed with this. -> Yes, checked private cli for aggregate and volume, fields were not be available there also. -> Below are the metric usage(from UM list) in Harvest 1.6 dashboard detail: |
Summary with the above changes: --> These are the counters which we don't currently fetch in Harvest 2.0: --> Dashboard perspective, These 3 counters were consumed in Harvest 1.6, but not available in Harvest 2.0: |
conf/zapi/cdot/9.8.0/volume.yaml
Outdated
@@ -55,6 +55,9 @@ counters: | |||
- snapshot-reserve-size => snapshot_reserve_size | |||
- percentage-snapshot-reserve => snapshot_reserve_percent | |||
- percentage-snapshot-reserve-used => snapshot_reserve_used_percent | |||
- overwrite-reserve => overwrite_reserve_total | |||
- overwrite-reserve-required => overwrite_reserve_avail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct mapping? Doesn't seem to match with avail definition . Does name overwrite_reserve_available
sound better?
* @element overwrite-reserve-required
* @type integer, optional
* @range [0..2^63-1]
* @desc The reserved size (in bytes) that is required to ensure
* that the reserved space is sufficient to allow all
* space-reserved files and LUNs to be overwritten when the
* volume is full. This field is valid only when the volume
* is online.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Lun, Qtree and Volume objects, Aggr would be next.
UM api response:
/usr/software/test/bin/ontapi -s -t dfm -p 443 10.234.172.232 umadmin netapp1! lun-iter
Harvest 2.0 response:
UM api response:
/usr/software/test/bin/ontapi -s -t dfm -p 443 10.234.172.232 umadmin netapp1! qtree-iter
Harvest 2.0 response:
UM api response:
/usr/software/test/bin/ontapi -s -t dfm -p 443 10.234.172.232 umadmin netapp1! volume-iter
used 1 volume for space related metrics and another for efficiency related metrics
for space: kavya_svm_lun_ss_del:/vol_with_qtree
Harvest 2.0 response:
for efficiency:
Harvest 2.0 response:
Not collected and not possible to handle in template/plugin for now: