Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add routes to network dashboard #1840

Merged
merged 3 commits into from
Mar 22, 2023
Merged

feat: Add routes to network dashboard #1840

merged 3 commits into from
Mar 22, 2023

Conversation

rahulguptajss
Copy link
Contributor

image

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2023
@rahulguptajss rahulguptajss linked an issue Mar 21, 2023 that may be closed by this pull request
Harvest should collect ip routes #1795
Closed
Hardikl
Hardikl previously approved these changes Mar 21, 2023
View reviewed changes
cmd/collectors/rest/plugins/netroute/netroute.go Show resolved Hide resolved
@cgrinds
Copy link
Collaborator

cgrinds commented Mar 21, 2023

Since the Routes panel in the dashboard only works with the RestCollector, we should note that in the Routes row

@rahulguptajss
Copy link
Contributor Author

Added like below

image

@rahulguptajss rahulguptajss merged commit afae87d into main Mar 22, 2023
@rahulguptajss rahulguptajss deleted the rg2-route-1 branch March 22, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@Hardikl Hardikl Hardikl left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harvest should collect ip routes
3 participants
@rahulguptajss @cgrinds @Hardikl