Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cluster health dashboard #1881

Merged
merged 30 commits into from
Apr 12, 2023
Merged

feat: cluster health dashboard #1881

merged 30 commits into from
Apr 12, 2023

Conversation

rahulguptajss
Copy link
Contributor

@rahulguptajss rahulguptajss commented Mar 31, 2023 •
edited
Loading

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 31, 2023
Hardikl
Hardikl reviewed Mar 31, 2023
View reviewed changes
cmd/collectors/rest/plugins/health/health.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/health/health.go Outdated Show resolved Hide resolved
grafana/dashboards/cmode/health.json Outdated Show resolved Hide resolved
cgrinds
cgrinds reviewed Mar 31, 2023
View reviewed changes
cmd/collectors/rest/plugins/health/health.go Outdated Show resolved Hide resolved
cmd/collectors/rest/plugins/health/health.go Outdated Show resolved Hide resolved
grafana/dashboards/cmode/health.json Show resolved Hide resolved
@rahulguptajss rahulguptajss marked this pull request as ready for review April 7, 2023 12:49
Hardikl
Hardikl previously approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

cgrinds
cgrinds reviewed Apr 12, 2023
View reviewed changes
grafana/dashboards/cmode/health.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/health.json Outdated Show resolved Hide resolved
cgrinds
cgrinds reviewed Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - two small change to the ems text:

  • Drop specifically
  • Change a => the

@rahulguptajss rahulguptajss merged commit e8c309c into main Apr 12, 2023
@rahulguptajss rahulguptajss deleted the rg2-health-alert branch April 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@Hardikl Hardikl Hardikl left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahulguptajss @cgrinds @Hardikl