feat: Harvest should define and document auth precedence #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardikl
reviewed
Apr 3, 2023
Comment on lines
+114
to
121
| if err != nil { | ||
| abs, err2 := filepath.Abs(credPath) | ||
| if err2 != nil { | ||
| abs = credPath | ||
| } | ||
| return fmt.Errorf("failed to read file=%s error: %w", abs, err) | ||
| } | ||
| if p == nil { |
There was a problem hiding this comment.
logic hasn't changed yet for absolute path?
There was a problem hiding this comment.
absolute path is only used in the error to help customers figure out the readfile error and where the file is being read from
pkg/auth/auth_test.go
Outdated
| name: "no default, poller credentials_file", | ||
| pollerName: "test", | ||
| want: PollerAuth{Username: "username", Password: "from-secrets-file"}, | ||
| defaultDefined: true, |
Hardikl
previously approved these changes
Apr 3, 2023
docs/configure-harvest-basic.md
Outdated
|
|
||
| | parameter | description | default | Link | | ||
| |----------------------|----------------------------------------------------------------------------|--------------|-----------------------------| | ||
| | `auth_sytle` | One of `basic_auth` or `certificate_auth` | `basic_auth` | [link](#Pollers) | |
There was a problem hiding this comment.
Description should add that it is an optional field if using credentials_file and credentials_script
rahulguptajss
previously approved these changes
Apr 4, 2023
rahulguptajss
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1867