Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle interface api call in svm rest/zapi #1912

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Apr 7, 2023

image

@cla-bot cla-bot bot added the cla-signed label Apr 7, 2023
@Hardikl Hardikl linked an issue Apr 7, 2023 that may be closed by this pull request
@@ -46,10 +46,6 @@ endpoints:
counters:
- ^^svm.name => svm
- ^session_security => ldap_session_security
- query: api/protocols/nfs/kerberos/interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you verify all of these endpoints. I see another endpoint error api/protocols/san/iscsi/credentials with infinity

2023-04-07T23:13:45+05:30 WRN rest/rest.go:463 > This instance is already processed. instKey is not unique Poller=Infinity collector=Rest:SVM instKey=rydeenSvmIscsi

@rahulguptajss
Copy link
Contributor

moving to draft as this needs more changes.

@rahulguptajss rahulguptajss marked this pull request as draft April 10, 2023 16:39
@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 11, 2023

Checking all the endpoint calls if it's svm scoped or not and if it's not then changing accordingly.

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 13, 2023

SVM api call investigation

  1. nsswitch
    nameservice-nsswitch-get-iter
    api/svm/svms
    svm scoped

  2. ciphers
    security-ssh-get-iter
    api/security/ssh/svms
    svm scoped

  3. cifs protocol
    cifs-security-get-iter
    cifs-server-get-iter
    api/protocols/cifs/services
    svm scoped - less data

  4. nfs protocol
    nfs-service-get-iter
    api/protocols/nfs/services
    svm scoped - less data

  5. audit
    fileservice-audit-config-get-iter
    api/protocols/audit
    svm scoped - less data

  6. fpolicy
    fpolicy-policy-status-get-iter
    api/protocols/fpolicy
    not a svm scoped --> Handled in plugin

  7. nis
    nis-get-iter
    api/name-services/nis
    svm scoped - less data

  8. ldap
    ldap-client-get-iter
    api/name-services/ldap
    svm scoped

  9. credentials
    iscsi-initiator-auth-get-iter
    api/protocols/san/iscsi/credentials
    not a svm scoped --> Handled in plugin. --> grafana dashboard changes

  10. iscsi service
    iscsi-service-get-iter
    api/protocols/san/iscsi/services
    not a svm scoped --> Handled in plugin

  11. cifs ntlm enabled
    cifs-security-get-iter
    api/private/cli/vserver/cifs/server/security
    svm scoped

@Hardikl Hardikl marked this pull request as ready for review April 13, 2023 14:26
@cgrinds cgrinds merged commit 7291775 into main Apr 17, 2023
@cgrinds cgrinds deleted the svm_interface_issue branch April 17, 2023 11:50
Hardikl added a commit that referenced this pull request Apr 17, 2023
* fix: handle interface api call in svm rest/zapi

* fix: handled non-svm scoped rest/zapi calls in plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rest SVM template should not use one to many endpoint URL
3 participants