Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: collect lif counters #1956

Merged
merged 4 commits into from
Apr 20, 2023
Merged

feat: collect lif counters #1956

merged 4 commits into from
Apr 20, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2023
@rahulguptajss rahulguptajss linked an issue Apr 19, 2023 that may be closed by this pull request
Collect LIF metrics in Harvest #1875
Closed
@Hardikl
Copy link
Contributor

Hardikl commented Apr 19, 2023

Minor: At Home values are true/false, do we want same as SM Yes/No ?

Hardikl
Hardikl previously approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@rahulguptajss
Copy link
Contributor Author

Minor: At Home values are true/false, do we want same as SM Yes/No ?

Yes I'll change

@rahulguptajss
Copy link
Contributor Author

Minor: At Home values are true/false, do we want same as SM Yes/No ?

Added

@cgrinds cgrinds merged commit a57da15 into main Apr 20, 2023
@cgrinds cgrinds deleted the rg2-lif branch April 20, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardikl Hardikl Hardikl approved these changes

@cgrinds cgrinds Awaiting requested review from cgrinds cgrinds is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect LIF metrics in Harvest
3 participants
@rahulguptajss @Hardikl @cgrinds