Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update alerts summary #1967

Merged
merged 1 commit into from
Apr 20, 2023
Merged

feat: update alerts summary #1967

merged 1 commit into from
Apr 20, 2023

Conversation

7840vz
Copy link
Contributor

@7840vz 7840vz commented Apr 20, 2023

To use proper label names

@cla-bot
Copy link

cla-bot bot commented Apr 20, 2023

Thank you for your interest in contributing to the Harvest project! We require contributors to sign our Corporate contributor license agreement (CCLA), and we don"t have the user(s) @7840vz on file. In order for us to review and merge your code, please follow the instructions in step 6 of creating a pull request.
After signing the CCLA, you can ask us to recheck this PR by posting @cla-bot check as a comment to the PR.

To use proper labels
@7840vz 7840vz changed the title Update alerts summary feat: update alerts summary Apr 20, 2023
@7840vz
Copy link
Contributor Author

7840vz commented Apr 20, 2023

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Apr 20, 2023

The cla-bot has been summoned, and re-checked this pull request!

@NetApp NetApp deleted a comment from rahulguptajss Apr 20, 2023
@cgrinds
Copy link
Collaborator

cgrinds commented Apr 20, 2023

Thanks @7840vz we received the CCLA and will review. Thanks for your contribution!

@rahulguptajss
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Apr 20, 2023
@cla-bot
Copy link

cla-bot bot commented Apr 20, 2023

The cla-bot has been summoned, and re-checked this pull request!

@NetApp NetApp deleted a comment from cla-bot bot Apr 20, 2023
@NetApp NetApp deleted a comment from cla-bot bot Apr 20, 2023
@@ -402,7 +402,7 @@ groups:
labels:
severity: "error"
annotations:
summary: "Storage VM stop succeeded for instance uuid [{{ $labels.instuuid }}]"
summary: "Storage VM stop succeeded for instance uuid [{{ $labels.inst_uuid }}]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svm_uuid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original message is related to instance uuid, and I received actual messages from EMS where it is inst_uuid not instuuid. So unsure if svm_uuid is related to this template.

@cgrinds cgrinds merged commit 1923d06 into NetApp:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants