ci: improve ems alert logging and event generation #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulguptajss
approved these changes
Apr 25, 2023
Hardikl
reviewed
Apr 26, 2023
| err := conf.LoadHarvestConfig(installer.HarvestConfigFile) | ||
| poller, err2 := conf.PollerNamed(TestClusterName) | ||
| dc1, err3 := conf.PollerNamed("dc1") | ||
| if err != nil && err2 != nil && err3 != nil { |
There was a problem hiding this comment.
I guess any one err != nil then we would be erroring out?
Comment on lines
+104
to
+105
| poller, err2 := conf.PollerNamed(TestClusterName) | ||
| dc1, err3 := conf.PollerNamed("dc1") |
There was a problem hiding this comment.
only password we fetched from dc1, right ?
Hardikl
reviewed
Apr 26, 2023
Comment on lines
+77
to
+78
| v := newAlertsData[issuingEms] - oldAlertsData[issuingEms] | ||
| if v > 1 { |
There was a problem hiding this comment.
This would not be as per our test case.
If we have issuing ems(ex. volume.offline) count as 3[oldAlertsData] earlier and after we fire resolving ems(volume.online), the issuing ems count would be reduced to 2[newAlertsData]
So, v = 2-3 = -1
Condition would be,
if v >= 0 {
error log
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.