Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: latency units should be in microseconds in harvest dashboard #2156

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

Hardikl
Hardikl previously approved these changes Jun 26, 2023
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! The bar continues to be raised on dashboard validation

cmd/tools/grafana/dashboard_test.go Show resolved Hide resolved
cmd/tools/grafana/dashboard_test.go Outdated Show resolved Hide resolved
cmd/tools/grafana/unit.go Outdated Show resolved Hide resolved
cmd/tools/grafana/unit.go Outdated Show resolved Hide resolved
@rahulguptajss
Copy link
Contributor Author

Addressed review comments

@cgrinds cgrinds merged commit 5c3a6b0 into main Jun 26, 2023
9 checks passed
@cgrinds cgrinds deleted the rg2-2149 branch June 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latency units should be in microseconds in harvest dashboard
3 participants