feat: Description fetched from ontap docs via cli #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if strings.Contains(expr, "/") || strings.Contains(expr, "*") || strings.Contains(expr, "+") || strings.Contains(expr, "-") { | ||
| // This indicates expressions with arithmetic operations, After adding appropriate description, this will be uncommented. | ||
| //t.Errorf(`dashboard=%s panel="%s" has many expressions`, dashPath, value.Get("title").String()) | ||
| fmt.Printf(`dashboard=%s panel="%s" has many expressions \n`, dashPath, title) |
There was a problem hiding this comment.
we want t.errorf and not fmt.
There was a problem hiding this comment.
yes, those are the cases for category 2 and 3.
t.errorf will be uncommented after the implementation of them later, else it will error out.
| } else { | ||
| // This indicates table/timeseries with more than 1 expressions, After deciding next steps, this will be uncommented. | ||
| //t.Errorf(`dashboard=%s panel="%s" has many expressions`, dashPath, value.Get("title").String()) | ||
| fmt.Printf(`dashboard=%s panel="%s" has many expressions \n`, dashPath, title) |
There was a problem hiding this comment.
we want t.errorf and not fmt.
Comment on lines
+182
to
+186
| func VisitAllPanels(data []byte, handle func(path string, key gjson.Result, value gjson.Result)) { | ||
| visitPanels(data, "panels", "", handle) | ||
| } | ||
|
|
||
| func visitPanels(data []byte, panelPath string, pathPrefix string, handle func(path string, key gjson.Result, value gjson.Result)) { |
There was a problem hiding this comment.
Why do we want to move these methods here? See if you can keep them in original file.
There was a problem hiding this comment.
Earlier it was in dashboard_test.go file, and need to use in other non-test files as well.
Thought would be non-test file should not use the method from test class, whereas reverse would be fine.
rahulguptajss
previously approved these changes
Nov 6, 2023
rahulguptajss
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hidden cli in generate, which would fetched metrics details from ontap and update the map of description with panels and later update the dashboards from the map.
Note: This is applicable only for category 1 where panel contains only 1 expression.