Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: usage of predict_linear function in volume dashboard #2763

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Mar 20, 2024

image

@rahulguptajss rahulguptajss marked this pull request as draft March 25, 2024 12:35
@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 1, 2024

Update from the investigation so far,

As discussed, I have tried to use the predict_linear function this way, Sample interval: 3 days, Prediction interval: 15 days.

There are few challenges while plotting this graph in Grafana

  • Query seem to be too slower as predict linear function takes topk query as input which is also slower in nature due to range and avg_over_time.
  • While plotting the graph, If we use sample interval as 3d then we can't provide the Time shift for more than 3d.
    Time shift is the value which can shift whole graph in right(future) or left(past) direction.

My idea was to plot a graph this way:
from current_date-15d(past) to current_date+15d(future) and current date will be at center. In this case, Time shift should be 15d.

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 5, 2024

image

@Hardikl Hardikl marked this pull request as ready for review April 5, 2024 11:24
@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 11, 2024

image

grafana/dashboards/cmode/volume.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/volume.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/volume.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/volume.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/volume.json Outdated Show resolved Hide resolved
grafana/dashboards/cmode/volume.json Outdated Show resolved Hide resolved
@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 17, 2024

Instead of using physical used and logical used, now using size used with clamping at 0% and 100% and made table size as full width which shows node and cluster data as well.
image

@@ -7561,6 +7561,282 @@
],
"title": "Volume Growth Rate",
"type": "row"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need Datacenter column in table.
Cluster should be a column after datacenter (at start) in table.
Default sorting should be on predicted value.
Is gradient bar percentage display better than text percentage value?
Node can be removed from table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Datacenter column added
  • Cluster column moved to 2nd
  • Node column removed
  • % changed to gradient
  • Default sort desc for predicted value.
image

@Hardikl Hardikl merged commit 7cfe66c into main Apr 25, 2024
6 checks passed
@Hardikl Hardikl deleted the hl_vol_trend branch April 25, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvest should add forecasting with Prometheus's predict_linear
3 participants