Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for LUN's "space-allocation" flag #135

Closed
stang opened this issue Jun 22, 2018 · 4 comments
Closed

Enable support for LUN's "space-allocation" flag #135

stang opened this issue Jun 22, 2018 · 4 comments

Comments

@stang
Copy link
Contributor

stang commented Jun 22, 2018

trident version: 18.01.0
backend: ontap-san
guest os: ubuntu16.04

We currently can't enable the space-allocation property when a LUN is created.

That option is required in order to allow the host OS to claim back some space (via fstrim for example) when using thin provisioning.

fstrim: FITRIM: Operation not supported

That have multiple consequences:

  • as we can't reclaim space, the SAN can't have a wrong information RE the available space on a LUN
  • from the SAN POV, the disk usage only increase — when full, the LUN goes offline and partition become readonly in the guest os.
  • from the kubernetes perspective, if we try to mount a PV that is link to a LUN that is offlline, it just timeout.

That really limit the usages and can have unexpected impact on a deployment.

@stang
Copy link
Contributor Author

stang commented Jul 5, 2018

hi @adkerr - I didn't find any CONTRIBUTE.md: what are the next steps in order to get this PR merged?

@adkerr
Copy link
Contributor

adkerr commented Jul 5, 2018

@stang

Thanks for the PR. Next we'll import the commit into our internal CI system and also code review the changes. If we agree with the changes and everything looks good test-wise we'll push it back out automatically. If we need any other updates from you we'll make sure the update the PR on github

@korenaren
Copy link
Contributor

Hi @stang - we've been heads down on some big rock features (Vol Import, CRDs, and other stuff)... sorry this has dragged on. Before we can review your code, we'd need you to sign our Corporate CLA. Is that something you'd be willing to consider? That's the first step. Still not sure what release we are targeting on this one, but can't do anything without the CCLA. I'll send it to you via thePub (Slack). Thanks!

@korenaren
Copy link
Contributor

Added in version 19.07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants