Allow to specify space-allocation option when using ontap_san backend #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stang
force-pushed
the
feature/add-space-allocation-support
branch
4 times, most recently
from
09da0a5
to
e25e70a
Compare
stang
changed the title
Signed-off-by: Stephane Tang <hi@stang.sh>
Signed-off-by: Stephane Tang <hi@stang.sh>
stang
force-pushed
the
feature/add-space-allocation-support
branch
from
e25e70a
to
88fad86
Compare
When not enabled, any LUN that belong to a volume that is perceived as full by the ONTAP will be put offline and lead to unexpected behavior on the guest OS. OTOH, having this option enabled is the preferred option for systems that are compatible with it, while most of the major OS we can find in the containers world are compatible. Signed-off-by: Stephane Tang <hi@stang.sh>
|
Would be great to see this merged! /gentlebump |
|
We are in desperate need of this feature...any chance it can be done in next release?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further details in: #135
In term of implementation, the
storage_drivers/ontap/api/azgolibrary was already supporting the option, so I just passed it down at theontap_sandriver level.It also recognize the
trident.netapp.io/spaceAllocatePVC's annotation in order to allow to modify that setting on a case per case basis.