installing an older version of an existing package fails silently

[andrewh1978]

Installing a newer version works, but installing an older version does nothing:

[root@test ~]# pkgin se nodejs
sqlrelay-nodejs-0.65.0  node.js API for SQL Relay
nodejs-6.7.0 <       V8 JavaScript for clients and servers
nodejs-4.6.0 =       V8 JavaScript for clients and servers
nodejs-0.8.28 >      V8 JavaScript for clients and servers
nodejs-0.12.17 >     V8 JavaScript for clients and servers
nodejs-0.10.48 >     V8 JavaScript for clients and servers

=: package is installed and up-to-date
<: package is installed but newer version is available
>: installed package has a greater version than available package
[root@test ~]# pkgin -y in nodejs-6.7.0
calculating dependencies... done.

1 packages to be upgraded:

nodejs-4.6.0

1 packages to be installed (0B to download, 871K to install):

nodejs-6.7.0

downloading packages...
removing packages to be upgraded...
removing nodejs-4.6.0...
pkg_install warnings: 0, errors: 0
installing packages...
installing nodejs-6.7.0...
pkg_install warnings: 0, errors: 0
reading local summary...
processing local summary...
[root@test ~]# pkgin se nodejs
sqlrelay-nodejs-0.65.0  node.js API for SQL Relay
nodejs-6.7.0 =       V8 JavaScript for clients and servers
nodejs-4.6.0 >       V8 JavaScript for clients and servers
nodejs-0.8.28 >      V8 JavaScript for clients and servers
nodejs-0.12.17 >     V8 JavaScript for clients and servers
nodejs-0.10.48 >     V8 JavaScript for clients and servers

=: package is installed and up-to-date
<: package is installed but newer version is available
>: installed package has a greater version than available package
[root@test ~]# pkgin -y in nodejs-4.6.0
calculating dependencies... done.
nothing to do.
[root@test ~]# pkgin se nodejs
sqlrelay-nodejs-0.65.0  node.js API for SQL Relay
nodejs-6.7.0 =       V8 JavaScript for clients and servers
nodejs-4.6.0 >       V8 JavaScript for clients and servers
nodejs-0.8.28 >      V8 JavaScript for clients and servers
nodejs-0.12.17 >     V8 JavaScript for clients and servers
nodejs-0.10.48 >     V8 JavaScript for clients and servers

=: package is installed and up-to-date
<: package is installed but newer version is available
>: installed package has a greater version than available package

[jperkin]

This diff appears to resolve the problem:

--- impact.c.orig	2016-02-08 16:27:12.000000000 +0000
+++ impact.c
@@ -241,8 +241,8 @@ deps_impact(Plisthead *impacthead, Pkgli
 				 * local pkgname didn't match deps, remote pkg
 				 * has a lesser version than local package.
 				 */
-				if (version_check(plist->full,
-					remotepkg) == 1) {
+				if (pdp->level > 0 &&
+				    version_check(plist->full, remotepkg) == 1) {
 					/*
 					 * proposing a downgrade is definitely
 					 * not useful, not sure what I want to

I think this is correct (ignore the downgrade problem if the package has been directly specified), but I'm going to leave it to bake in the SmartOS 2017Q3 builds first before committing here.

[jperkin]

Likely fixed a long time ago, but certainly should be in 23.8.0.