Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Num Representation in Existing Network Instances #20

Open
sbondorf opened this issue May 2, 2018 · 2 comments
Open

Change Num Representation in Existing Network Instances #20

sbondorf opened this issue May 2, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@sbondorf
Copy link
Collaborator

sbondorf commented May 2, 2018

Networks are composed of servers and flows that are, in turn, partially defined by curves. These curves naturally hold numbers (Num instances) of a certain representation defined in the Calculator. In case the representation is changed (e.g., in tests), the current solution is to create a new Network instance. Instead, a Network instance should be able to just trigger updates of its member variables.

@sbondorf sbondorf added enhancement New feature or request good first issue Good for newcomers labels May 2, 2018
@matyesz
Copy link
Collaborator

matyesz commented Dec 19, 2018

Is there any possible way/API to convert a curve into a new NumBackend? I think we will need some conversion faciltiy from one backend to the other if we want to keep the original values of the curves.

@sbondorf
Copy link
Collaborator Author

There was no progress in this issue yet although it seems a straight-forward task.
The biggest problem I see is converting a Real{Double,Single}Precision-backed curve to a Rational{Ø,Big}Int-backed one. Besides the obvious difference in expressiveness, there is the case where curve resulted from a sequence of operations and was thus subject to rounding errors / the machine epsilon problem.
Having said that, maybe we should remove the "good first issue" label.

@sbondorf sbondorf removed the good first issue Good for newcomers label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants