Skip to content

Commit

Permalink
fix: メニューの表示設定、パブリックのトップページをOFFにした後、再度設定開いても正しく表示されるように修正
Browse files Browse the repository at this point in the history
  • Loading branch information
akagane99 committed Mar 12, 2018
1 parent 80ff44a commit 4a3f989
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions View/Helper/MenuFormHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function beforeRender($viewFile) {
* @return string HTMLタグ
*/
public function checkboxMenuFramesRoom($roomId, $room, $pageId) {
list($prefixInput, $isFidden, $html) = $this->_getRoomPrefix($roomId, $room, true);
list($prefixInput, $isFidden, $html) = $this->_getRoomPrefix($roomId, $room);

$childPageIds = [];
$childPageIds = $this->getRecursiveChildPageId($pageId, $childPageIds);
Expand Down Expand Up @@ -114,7 +114,7 @@ public function checkboxMenuFramesPage($roomId, $room, $pageId, $menu, $rootRoom
return $html;
}

list($roomPrefixInput, $roomIsFidden, ) = $this->_getRoomPrefix($rootRoomId, $rootRoom, false);
list($roomPrefixInput, $roomIsFidden, ) = $this->_getRoomPrefix($rootRoomId, $rootRoom);
$roomDisabled = (bool)Hash::get(
$this->_View->request->data, $roomPrefixInput . '.' . $roomIsFidden
);
Expand Down Expand Up @@ -176,10 +176,9 @@ public function getRecursiveChildPageId($pageId, $result) {
*
* @param int $roomId Room.id
* @param array $room ルームデータ
* @param bool $isRoom ルームのチェックボックスからの呼び出しか
* @return array
*/
protected function _getRoomPrefix($roomId, $room, $isRoom) {
protected function _getRoomPrefix($roomId, $room) {
$html = '';
if (Hash::get($room, 'Room.parent_id') === Space::getRoomIdRoot(Space::PRIVATE_SPACE_ID)) {
$prefixInput = 'MenuFrameSetting';
Expand All @@ -189,7 +188,7 @@ protected function _getRoomPrefix($roomId, $room, $isRoom) {
$pageIdTop = $room['Room']['page_id_top'];
// ページ一覧で、パブリックルームのルーム表示のみ、ページがないため、$room['Room']['page_id_top']から取れない。
// そのため、Space::getPageIdSpace(Space::PUBLIC_SPACE_ID)で page_idをセット
if ($isRoom && $roomId === Space::getRoomIdRoot(Space::PUBLIC_SPACE_ID, 'Room')) {
if ($roomId === Space::getRoomIdRoot(Space::PUBLIC_SPACE_ID, 'Room')) {
$pageIdTop = Space::getPageIdSpace(Space::PUBLIC_SPACE_ID);
}

Expand Down

0 comments on commit 4a3f989

Please sign in to comment.