Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nc2ToNc3Registration.php #45

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Update Nc2ToNc3Registration.php #45

merged 2 commits into from
Dec 14, 2018

Conversation

akagane99
Copy link
Contributor

fix: 登録フォーム移行で、NC3側の登録フォーム取得時のID指定間違いを修正

NetCommons3/NetCommons3#1395

バグ修正です。
移行ツールは、トラビステストが実質ないため、マージします。

fix: 登録フォーム移行で、NC3側の登録フォーム取得時のID指定間違いを修正
fix: 登録フォーム移行、NC2ではOKだった全角空白のみの選択肢も、NC3ではRegistrationChoiceモデルでvalidateエラーになるため、取り除く処理をメソッド化
@akagane99 akagane99 merged commit 9de1755 into master Dec 14, 2018
@akagane99 akagane99 deleted the bugfix branch December 14, 2018 17:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Registration.php 49 0.0%
Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 0
Relevant Lines: 11237

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Dec 14, 2018

Pull Request Test Coverage Report for Build 22

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Registration.php 49 0.0%
Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 0
Relevant Lines: 11237

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants