Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 左カラムなど常時表示の場所にログインモジュールを置いて移行するとNC3ではページ閲覧しようとするとログイン画面に強制リダイレクトされるため、移行しない #46

Merged
merged 1 commit into from
Dec 26, 2018

Conversation

akagane99
Copy link
Contributor

Update Nc2ToNc3Plugin.php
NetCommons3/NetCommons3#1062

動作未確認です。
動作確認後、マージしようと思ってます。

fix: 左カラムなど常時表示の場所にログインモジュールを置いて移行するとNC3ではページ閲覧しようとするとログイン画面に強制リダイレクトされるため、移行しない
NetCommons3/NetCommons3#1062
@coveralls
Copy link

Pull Request Test Coverage Report for Build 28

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Plugin.php 8 0.0%
Totals Coverage Status
Change from base Build 26: 0.0%
Covered Lines: 0
Relevant Lines: 11247

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 28

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Plugin.php 8 0.0%
Totals Coverage Status
Change from base Build 26: 0.0%
Covered Lines: 0
Relevant Lines: 11247

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 25, 2018

Pull Request Test Coverage Report for Build 28

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Plugin.php 8 0.0%
Totals Coverage Status
Change from base Build 26: 0.0%
Covered Lines: 0
Relevant Lines: 11247

💛 - Coveralls

@akagane99
Copy link
Contributor Author

動作確認しました。
loginモジュールがこれで移行されなくなったため、マージします。

@akagane99 akagane99 merged commit 023b2b0 into master Dec 26, 2018
@akagane99 akagane99 deleted the bugfix branch December 26, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants