Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload_pathの末尾に/なければ付ける&Nc2Page.display_flag = 2 (プライベートスペース使用不可)に対応 #47

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

akagane99
Copy link
Contributor

@akagane99 akagane99 commented Dec 26, 2018

NetCommons3/NetCommons3#1398
NetCommons3/NetCommons3#1399

動作確認中です。
問題なければ、マージしようと思ってます。

fix: upload_pathの末尾に/なければ付ける
fix: Nc2Page.display_flag = 2 (プライベートスペース使用不可)がありえるため、対応
@akagane99 akagane99 changed the title fix: upload_pathの末尾に/なければ付ける fix: upload_pathの末尾に/なければ付ける&Nc2Page.display_flag = 2 (プライベートスペース使用不可)がありえるため、対応 Dec 26, 2018
@akagane99 akagane99 changed the title fix: upload_pathの末尾に/なければ付ける&Nc2Page.display_flag = 2 (プライベートスペース使用不可)がありえるため、対応 fix: upload_pathの末尾に/なければ付ける&Nc2Page.display_flag = 2 (プライベートスペース使用不可)に対応 Dec 26, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 33

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 73 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Console/Command/Nc2ToNc3Shell.php 18 0.0%
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Room.php 55 0.0%
Totals Coverage Status
Change from base Build 29: 0.0%
Covered Lines: 0
Relevant Lines: 11256

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Dec 26, 2018

Pull Request Test Coverage Report for Build 33

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 73 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
app/Plugin/Nc2ToNc3/Console/Command/Nc2ToNc3Shell.php 18 0.0%
app/Plugin/Nc2ToNc3/Model/Nc2ToNc3Room.php 55 0.0%
Totals Coverage Status
Change from base Build 29: 0.0%
Covered Lines: 0
Relevant Lines: 11256

💛 - Coveralls

@akagane99
Copy link
Contributor Author

動作確認しました。
マージします。

@akagane99 akagane99 merged commit a38c06b into master Dec 26, 2018
@akagane99 akagane99 deleted the bugfix branch December 26, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants