Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

handshake request parse error fix #751

Merged
merged 1 commit into from
Aug 17, 2015
Merged

Conversation

BonneVoyager
Copy link
Contributor

Problem occured after pomelo client (unity 3d version) tried to handshake with the server. And the errror was an accident, which happened after removing ending quotes for JSON keys for handshake message (so it's not pomelo unity 3d client error, it's a server error). Then the game server crashed with following message:

{type":"unity-socket", version":"1.0.0"}
 ^

SyntaxError: Unexpected token t
    at Object.parse (native)
    at decode (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/connectors/common/coder.js:38:21)
    at null.<anonymous> (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/components/connector.js:223:29)
    at emit (events.js:95:17)
    at handleData (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/connectors/common/handler.js:42:10)
    at handle (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/connectors/common/handler.js:53:5)
    at null.<anonymous> (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/connectors/hybridsocket.js:41:7)
    at emit (events.js:95:17)
    at readBody (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/connectors/hybrid/tcpsocket.js:183:12)
    at ondata (/home/ovos/lebensnets/game-server/node_modules/pomelo/lib/connectors/hybrid/tcpsocket.js:104:16)

logging for this case is:

[2015-08-13 13:59:47.404] [INFO] crash-log - [.../node_modules/pomelo/lib/master/master.js] [connector],[connector-1],[1439467187404],[disconnect]

[2015-08-13 13:59:47.405] [WARN] pomelo - [.../node_modules/pomelo/lib/master/starter.js] child process exit with error, error code: 8, executed command: /usr/bin/nodejs

This means that any client sending incorrect handshake message could stop the server with process error.

@BonneVoyager BonneVoyager changed the title handshare request parse error fix handshake request parse error fix Aug 13, 2015
py8765 added a commit that referenced this pull request Aug 17, 2015
handshake request parse error fix
@py8765 py8765 merged commit 4c0732a into NetEase:master Aug 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants