Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
work around ubuntu 20.10 build issue
NetHack was trying to suppress warn_unused_result in include/tradstdc.h, by defining warn_unused_result to an empty string. That began causing a build error in a system-supplied header file cdefs.h when using 20.10 ubuntu impish. Try skipping that in tradstdc.h for any linux, unless the NetHack build defines GCC_URWARN to force it into play.
- Loading branch information
1cb5dc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @nhmall, which also fixes facebookresearch/nle#297. Note that the issue also shows up in the current stable version 3.6.6 and should probably be cherry-picked.
1cb5dc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heiner , good suggestion about 3.6.6 - it has now been cherry-picked into branch NetHack-3.6.