Support for dotnetcore (netstandard1.6)

[dudymas]

I think this is sorta obvious, but hey, the goal here is to eventually build this library in with dotnetcore on netstandard 1.6

Objections? Thoughts? Am I nuts because this is impossible?

I'm thinking about sinking my teeth into this unless folks like @somdoron already are.

[somdoron]

I think it is possible... Please make a PR :)

[sSeewald]

Any updates on this topic?

[somdoron]

@sSeewald can you make a PR? shouldn't be complicated...

[sSeewald]

@somdoron I can look into this. They changed allot in System.Security.Cryptography. So... when i look into my glass ball it seems not that trivial.

[dnfield]

I've created a port with all unit tests passing. Created pull request for it.

[csmorley]

Hi all, just added from nuget and get the following Warning NU1701 Package 'NetMQ.Security 1.0.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project. any idea when a .netcore version will be available from nuget?

[dnfield]

I did this patch a ways back and never got a response. My sense is the project has been abandoned

[csmorley]

Thanks Dan, that would be a shame as without security I can't use NetMQ. Will take a look at your code and use the source

…

On Fri, 13 Jul 2018, 04:07 Dan Field, ***@***.***> wrote: I did this patch a ways back and never got a response. My sense is the project has been abandoned — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFUj1UkmTRhBFxKx8SXhXOYEX_91eGWOks5uF-TGgaJpZM4KXPg3> .

[somdoron]

@dnfield can i make you admin of the project?

[dnfield]

I'd be happy to contribute when I can, but to be honest I'm not actively using it at this point and won't be for the foreseeable future.

[generik0]

MonoAndroid suport would also be good.
The 1.6 build can probably build to multiple targets.

[drewnoakes]

Doesn't this already target netstandard1.6?

NetMQ.Security/src/NetMQ.Security/NetMQ.Security.csproj

Lines 1 to 5 in cac555b

	<Project Sdk="Microsoft.NET.Sdk">
	<PropertyGroup>
	<TargetFramework>netstandard1.6</TargetFramework>
	<AssemblyName>NetMQ.Security</AssemblyName>

[generik0]

MonoAndroid05+06+07 does not like standard. But I see you are using a type that is only supported by net471.

Don’t stress about it. Found another solution:-)

[drewnoakes]

Which type is that? Are you adding a different TargetFramework in your own build?

[generik0]

You can e.g. aff a net4, nett452, net461 and/or net471 t the frameworks in the csproj
Then make a nuspec that adds e.g. the net452 into a MonoAndroid folder for the nuget.
Then it "just works" Installing the net framework for monoandroid60+
I normally add into the nuspec a monoandorid81 that has netstand2.0 builds

e.g. in nuspec (NB id is passed from the csproj):

<files>
    <file src="bin\$configuration$\net452\$id$.dll" target="lib\MonoAndroid50\$id$.dll" />
    <file src="bin\$configuration$\net452\$id$.pdb" target="lib\MonoAndroid50\$id$.pdb" />
    <file src="bin\$configuration$\netstandard2.0\$id$.dll" target="lib\MonoAndroid81\$id$.dll" />
    <file src="bin\$configuration$\netstandard2.0\$id$.pdb" target="lib\MonoAndroid81\$id$.pdb" />
    <file src="bin\$configuration$\net452\$id$.dll" target="lib\net452\$id$.dll" />
    <file src="bin\$configuration$\net452\$id$.pdb" target="lib\net452\$id$.pdb" />
    <file src="bin\$configuration$\netstandard2.0\$id$.dll" target="lib\netstandard2.0\$id$.dll" />
    <file src="bin\$configuration$\netstandard2.0\$id$.pdb" target="lib\netstandard2.0\$id$.pdb" />
    <file src="**\*.cs" target="src\$id$" exclude="**\bin\**\*.*;**\obj\**\*.*" />
    <file src="$id$.csproj" target="src\$id$" exclude="**\bin\**\*.*;**\obj\**\*.*" />
  </files>

This is what i have found works atleast for out xamavarin. I had major problems when i did not include the mono references

[dungpa]

We are a happy production user of NetMQ.Security.
Currently, we are unable to migration to .NET 6/.NET 8 because NetMQ.Security isn't compatible with netstandard.

netstandard1.6 support at #2 was merged into master a long time ago.
@somdoron @drewnoakes @dnfield Can someone publish a new NuGet package version compatible with netstandard1.6?