Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

Added Windows CE compatibility and TeamCity independency #21

Merged
merged 5 commits into from
Nov 21, 2016
Merged

Added Windows CE compatibility and TeamCity independency #21

merged 5 commits into from
Nov 21, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2016

This pull request has the following changes:

  • New project for Windows CE (.NET 3.5 Compact Framework).
  • Changes to allow building for all targets from batch script instead to rely only on TeamCity.
  • Changes to allow creating NuGet package from batch script instead to rely only on TeamCity.
  • Changes to include net35-cf and netstandard1.6 targets into NuGet package.

Fabrício Godoy added 5 commits October 26, 2016 18:10
New project for v3.5 build and shared AssemblyInfo file
c59d973
New project for Windows CE and changes for compatibility
9311a86
Building changes for Windows CE project
9a4eae3 
- Removed unused references.
- Changed deploy directory to not include "Net35CF" suffix.
- Changed output path to match another projects.
- Change to sign assembly.
- Updated assembly version.
Changes to build locally
6fcb7a2 
- Renamed GeoAPI.Net35CF project to GeoAPI.CF.
- Removed GeoAPI.Net35 project.
- Updated NuGet package specification to include net35-cf and new version number.
- New scripts to build libraries and NuGet package.
- Updated NuGet executable.
Improved building script and added .NET Core to NuGet package
6583525
@skarllot
Copy link
Contributor

Generated NuGet packages

Release.zip

@skarllot skarllot mentioned this pull request Oct 28, 2016
Closed
@DGuidi
Copy link
Contributor

DGuidi commented Oct 28, 2016 •
edited
Loading

Actually, I'm against introducing support for WinCE platform, that (I think) is a legacy platform.

@FObermaier
Copy link
Member

A few questions:

  • Do the msbuild scripts still work, or did you change everything to use the vbs-script?
  • Why did you increase the GeoAPI version, did you/we add functionality or is it just the additional platform?

I'm not against introducing the WinCE platform. Net20 is legacy, too. I'd like to change the NetCore project to rely on NetStandard1.0 instead of 1.6, but we can change that afterwards.

@skarllot
Copy link
Contributor

  • The msbuild script does not depend of vbscript, the NuGet script do. This can be changed, the vbscript is used to read assembly version to use on NuGet package version.
  • I'm increased the version just because the new platform, the API is exactly the same.
  • I can run some tests on NetStandard1.0 to check whether need changes to run.

@xivk
Copy link
Contributor

xivk commented Nov 18, 2016

Can we merge this @FObermaier ? Any changes that need doing before?

@xivk
Copy link
Contributor

xivk commented Nov 18, 2016

Do we have to remove the windows CE stuff then?

@FObermaier
Copy link
Member

IMHO we can merge this, but before releasing I'd like to have the Net.Standard version set as low as possible, Increasing the version number is not indicated when adding a build target. The package version must increase though.

@FObermaier FObermaier merged commit 3c28b52 into NetTopologySuite:master Nov 21, 2016
@FObermaier
Copy link
Member

According to this SO post we don't need the GUID at all.
I havn't seen projects that deal with the GUID in such a way.

@DGuidi DGuidi mentioned this pull request Jan 16, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skarllot @DGuidi @FObermaier @xivk